Updating to latest API changes. Added in delimiter support for get_bucket. Minor bug fixes. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to the Put and Get object commands so that the addition of the offset does not break any existing code.
…listObjectsForDirectory to translate '\' to '/'
Contributor
There was a problem hiding this comment.
I think you mentioned this yesterday: NotImplementedException is better here, but apparently that's not actually in the standard library :(. UnsupportedOperationException means "I don't intent to support this", where NotImplementedException means "I don't support this YET".
Maybe as a compromise you could add //TODO: implement this?
In ReSharper NotImplementedException shows up in the task list just like TODO comments.
…an be validated by client code. Added an implementation that does that called VerifyingFileObjectGetter.
Contributor
There was a problem hiding this comment.
Can we make this a "getHeaders()" method instead?
…o made a Md5Hash to abstract out how the hash is actually is represented.
Contributor
There was a problem hiding this comment.
I just cross-referenced this with the server code and I think this will break regular S3 GETs. If there's no job id we shouldn't send the offset.
hansdude
pushed a commit
that referenced
this pull request
Aug 5, 2014
Updating to latest API changes. Added in delimiter support for get_bucket. Minor bug fixes.
scribe
pushed a commit
to scribe/ds3_java_sdk
that referenced
this pull request
Oct 22, 2020
Updating a package name that is incorrectly named
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.