Object complete handler #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is closed before we fire customer onCompleted events. This is specific to read jobs. Needs implementing for both read ans write.
…d before we fire customer onCompleted events.
… the right number of times.
…added to the right job part tracker.
…right job part tracker.
…bject completion handler.
…ompletion handlers first.
… correct object part tracker.
…into object_complete_handler
…into object_complete_handler
…into object_complete_handler
rpmoore
suggested changes
Oct 14, 2016
| private final JobPartTracker internalJobPartTracker; | ||
|
|
||
| protected JobPartTrackerDecorator(final List<Objects> chunks, final EventRunner eventRunner) { | ||
| clientJobPartTracker = JobPartTrackerFactory.buildPartTracker(Iterables.concat(getAllBlobApiBeans(chunks)), eventRunner); |
Contributor
There was a problem hiding this comment.
Is Iterables.concat required here?
Contributor
Author
There was a problem hiding this comment.
Don't know. I just copied that from what was there already. I'll see.
Contributor
Author
There was a problem hiding this comment.
It would appear not
rpmoore
approved these changes
Oct 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to address https://jira.spectralogic.com/browse/JSDK-165: Our ObjectCompleted Handler must run first
Basically, this moves firing events into the JobImpl base class, which uses a wrapper to create 2 JobPartTracker's: 1 used to fire events we register to close channels we open when Job.transfer is called; the other to fire events customers register for.
Most of this pull request is a set of integration tests. Because the nature of the problem we're solving is non-determinism in firing events, we can't rely solely of having event handlers fire in the expected order in the tests, because we don't know if firing in the right order is deterministic or not. So, we check that the JobPartTrackers have the correct number of event handlers, internal vs. client, then inject an interceptor to ensure that we're calling the event handlers in the right order.