Fix integration tests that broke with latest http proxy #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… I injected a fault into the file lesmis-copies.txt. Using a different file in this test is still valid, because we're usiong a ds3 client shim that also injects faults, which exercises the logic we're trying to validate with this test -- retry logic. I'll update this test when I get finished with the partial read retry stuff I'm working on, which is why I monkeyed with the http proxy to begin with :(
DenverM80
approved these changes
Dec 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An integration test broke when I introduced a change into the http proxy, where I injected a fault into the file lesmis-copies.txt. Using a different file in this test is still valid, because we're using a ds3 client shim that also injects faults, which exercises the logic we're trying to validate with
this test -- retry logic. I'll update this test when I get finished with the partial read retry stuff I'm working on, which is why I monkeyed with
the http proxy to begin with :(