Skip to content

Conversation

@GraciesPadre
Copy link
Contributor

that set directory permissions for the evil that is Redmond.

objects.add(obj);
putObjectThenRunVerification(new FileSystemHelperImpl(), new ResultVerifier() {
@Override
public void verifyResult(ObjectStorageSpaceVerificationResult result, long totalRequiredSize) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing finals

directory.toFile().setWritable(false);
if (org.apache.commons.lang3.SystemUtils.IS_OS_WINDOWS) {
Runtime.getRuntime().exec("icacls dir /deny Everyone:(WD)");
Thread.sleep(5000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment would be good here stating the necessity of the sleep

@rpmoore rpmoore merged commit 06fe8f3 into SpectraLogic:master Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants