5.0 API #542
Merged
5.0 API #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraciesPadre
approved these changes
Feb 21, 2018
Contributor
GraciesPadre
left a comment
GraciesPadre
left a comment
There was a problem hiding this comment.
Quite nice. One very minor nit, but not worth doing anything about, unless you'll be visiting again.
| final Ds3ClientHelpers helpers = Ds3ClientHelpers.wrap(client); | ||
|
|
||
| final Ds3ClientHelpers.Job job = helpers.startWriteJob(bucketName, ImmutableList.of(obj)); | ||
| job.transfer(new Ds3ClientHelpers.ObjectChannelBuilder() { |
Contributor
There was a problem hiding this comment.
An observation -- this might be easier to read as a lamda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated 5.0 API
Updated Ds3Object to include optional
VersionIdUpdated unit test payloads to match updated payloads
Updated integration tests to ensure jobs are canceled before attempting to delete bucket
Added
versionsto canonicalized query parameters in signatureAdded versioning test