Streaming Fix - JSDK-298 #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It doesn't look like we've enabled git lfs for this repo. We probably should do that and push that zip file in there. |
rpmoore
reviewed
Nov 9, 2019
| size = channel.read(dst); | ||
| position += size; | ||
| return size; | ||
| return Long.valueOf(size).intValue(); |
Contributor
There was a problem hiding this comment.
Did the lack of this cause problems when a blob was over 4GB?
Contributor
Author
There was a problem hiding this comment.
This is one of the places it failed, I can't say if this is wholly the issue though.
rpmoore
reviewed
Nov 9, 2019
| .map(bulkObject -> bulkObject.getOffset()) | ||
| .max(Long::compareTo).orElseGet(() -> blob.getOffset()); | ||
|
|
||
| final boolean isReadOnly = ((SeekableByteChannelDecorator) seekableByteChannel).wrappedSeekableByteChannel() instanceof ReadOnlySeekableByteChannel; |
Contributor
There was a problem hiding this comment.
Why is the cast here needed in order to perform the instanceof check?
Contributor
Author
There was a problem hiding this comment.
We know it is a SeekableByteChannelDecorator because we wrap it further up, but the wrappedSeekableByteChannel() is only on the Decorator
rpmoore
reviewed
Nov 9, 2019
| return makePutTransferMethod(); | ||
| } | ||
| }); | ||
| (client, masterObjectList, eventDispatcher) -> new PutSequentialBlobStrategy(ds3Client, |
rpmoore
approved these changes
Nov 9, 2019
rpmoore
pushed a commit
that referenced
this pull request
Nov 9, 2019
* Fixed * Oops * Imports * Imports * Imports
rpmoore
added a commit
that referenced
this pull request
Jan 30, 2020
* JSDK-297: Add new Header value to HEAD Object. (#577) * JSDK-297: Add new Header value to HEAD Object. Adding in parsing for new headers 'creation-date' and 'version-id' into the head object response payload. * JSDK-297: Add new Header value to HEAD Object. Generated head object call with new header parsing. * Streaming Fix - JSDK-298 (#579) * Fixed * Oops * Imports * Imports * Imports * cherrypicking streaming blob change and reving to 5.0.6 * Merging missing changes from 5.1.2 Co-authored-by: RachelTucker <RachelTucker@users.noreply.github.com> Co-authored-by: Eric <192110+scribe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a hack, but it passes all the tests now.