Json files #278
Merged
Json files #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowleya
approved these changes
Feb 10, 2020
| :type json_folder: str | ||
| """ | ||
| # Steps are tojson, validate and writefile | ||
| progress = ProgressBar(3, "Converting to JSON MachineGraph") |
There was a problem hiding this comment.
Oops, this isn't a machine graph!
fixed progress bar message
dkfellows
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed json writes (when not required for java) to reports
Added an partition to n keys one
needs SpiNNakerManchester/SpiNNFrontEndCommon#543 to actaully work but can be merged first