New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iss: pick the correct inet_pton. #639

Closed
zimmerle opened this Issue Jan 7, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@zimmerle
Member

zimmerle commented Jan 7, 2014

As reported by Steffen from Apache Lounge (http://www.apachelounge.com/), we are making an incorrect decision on which inet_pton to use.

We have our custom version of inet_pton and depending on windows version, we also have it available through windows APIs. If so, we should use the windows version.

A good way to identify the windows versions:
http://msdn.microsoft.com/en-us/library/aa383745.aspx

By applying #if !(NTDDI_VERSION >= NTDDI_VISTA) on the msc_util.c we may good to go.

@zimmerle
@zimmerle

This comment has been minimized.

Show comment
Hide comment
@zimmerle

zimmerle Feb 26, 2014

Member

Fixed by: 831e598

Member

zimmerle commented Feb 26, 2014

Fixed by: 831e598

@zimmerle zimmerle closed this Feb 26, 2014

@zimmerle zimmerle added this to the testing milestones milestone Mar 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment