Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
iss: pick the correct inet_pton. #639
As reported by Steffen from Apache Lounge (http://www.apachelounge.com/), we are making an incorrect decision on which inet_pton to use.
We have our custom version of inet_pton and depending on windows version, we also have it available through windows APIs. If so, we should use the windows version.
A good way to identify the windows versions:
By applying #if !(NTDDI_VERSION >= NTDDI_VISTA) on the msc_util.c we may good to go.
The branch with test implementation available at: https://github.com/SpiderLabs/ModSecurity/tree/my_inet_pton
Buildbots has no complaints about it:
It still demands more tests to before merge.