New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation changes to 3.1 #1109

Merged
merged 13 commits into from Aug 8, 2018

Conversation

Projects
None yet
2 participants
@csanders-git
Collaborator

csanders-git commented May 31, 2018

@csanders-git

This comment has been minimized.

Collaborator

csanders-git commented May 31, 2018

ID Renumbering was done for 3.x. Since this is the second release in the series, and we've had like a year. I've removed the 3.0 id_numbering information.

@dune73

This comment has been minimized.

Collaborator

dune73 commented May 31, 2018

At first sight, removing the renumbering stuff makes a lot of sense. But there are still a lot of people on 2.2.x (Linux distros!) and they might want to migrate to 3.1 directly (Linux distros!). I do not see much problem keeping the files around for another year or two.

And huzzah to the many new contributors.

@csanders-git csanders-git force-pushed the csanders-git:3.1_cleanup branch from 0bd84b9 to 35dc05e May 31, 2018

@dune73

This comment has been minimized.

Collaborator

dune73 commented Jun 5, 2018

Typos in CHANGES:

line 27: sibbling
line 30: exlcusion
line 32: non-necessary period after docuwiki
line 43: readme should better be README
either line 36 or line 47 is redundant
line 57: I contributed to these guidelines too
line 68: that's more of a bug description than a changelog entry
line 79: regex -> regexes

@csanders-git csanders-git force-pushed the csanders-git:3.1_cleanup branch from e63a99f to e785546 Aug 7, 2018

@csanders-git csanders-git merged commit 49c00b8 into SpiderLabs:v3.1/dev Aug 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment