Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add rule 933200 PHP Wrappers #1172
Referring to #1171 I'm testing this rule in production, and at the moment seems to works fine without FP in PL1. About the wrapper
changed the title from
Add rule 933200 PHP Wrappers
(draft: do not merge yet) Add rule 933200 PHP Wrappers
Aug 17, 2018
Nice and welcome PR. It's not going into 3.1, but we are open to merging into 3.2.
Thanks for reply @dune73
yes, I think that the
yes, I've put it there for "continuity" from the 933140. What's the better approach? keep rules ordered by their id? maybe yes... it sounds more clean. What do you think about?
Nice! I'll add the presentation available on the author's github repo.
Can I push a new commit with all changes on this PR?
Yes, please go ahead with committing to this PR.
I think it's safe to remove the capture / TX.0. And the position makes sense, but maybe add a remark in the comments, that it is very close to the PHP I/O streams. Weird rule order till happen as we move along, so it's best to just live with it. A renumbering would be far worse.