New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mostly redundant 944220 in favor of 944240 #1198

Merged
merged 8 commits into from Oct 14, 2018

Conversation

Projects
None yet
5 participants
@dune73
Collaborator

dune73 commented Oct 5, 2018

This rule leads to serious ModSec disruption in rare occasions as reported in #1185.

944240 has almost the same coverage (minus keyword runtime and processbuilder).

franbuehler and others added some commits Aug 13, 2018

Minor fixes (#1176) (#1179)
* Remove auditlog

No other rules specify it.

* Add missing quotes and drop rev
Merge pull request #1194 from fzipi/v3.1/dev-fix-typo
Fix small typo in variable
@dune73

This comment has been minimized.

Collaborator

dune73 commented Oct 8, 2018

This PR also involves commit 7c822cc because said commit was merged into 3.1 (without being pushed into 3.2 first). So with this PR against 3.2 also brings said commit.

@dune73

This comment has been minimized.

Collaborator

dune73 commented Oct 8, 2018

Meanwhile, PR #1201 fixed the situation for 3.2. So the change of util/docker/docker-entrypoint.sh in here is redundant.

@lifeforms lifeforms merged commit fd121a3 into SpiderLabs:v3.2/dev Oct 14, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

lifeforms added a commit that referenced this pull request Oct 14, 2018

@dune73

This comment has been minimized.

Collaborator

dune73 commented Oct 14, 2018

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment