Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
New rule 941360 to detect JSFuck and Hieroglyphy at PL1 #1261
referenced this pull request
Dec 26, 2018
my bad sorry :) it may be interesting to have this tested in front of a WP or some other CMS that uses lots of  on their payloads before releasing 3.2
@fgsch: That's what I planned to do, but did not have time earlier. Now I did and it messed it up. So I'm planning to throw this away and do a new, clean PR.
Here is what I did. What's wrong with this?
I see the tests passing now. But anyways, I guess I should have cherrypicked the right commit.
@dune73 not sure. I normally do the following (assuming origin points to this repo):
You should be able to fix this PR without closing it, for example: