New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unneeded capture groups and tidy up #1270

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
2 participants
@fgsch
Copy link
Collaborator

fgsch commented Dec 25, 2018

Continued from #1252. This should address the remaining patterns.

These are the last 2 rules having capture groups that were not used.

@fgsch fgsch requested a review from franbuehler Dec 25, 2018

@fgsch fgsch force-pushed the fgsch:fgsch/regexp-fixes-3 branch from 3594ea7 to 296f066 Dec 25, 2018

@fgsch fgsch removed the v3.2-dev label Dec 25, 2018

@fgsch fgsch added this to the CRS v3.2.0 milestone Dec 25, 2018

@fgsch fgsch force-pushed the fgsch:fgsch/regexp-fixes-3 branch from 296f066 to 4573371 Dec 29, 2018

Drop unneeded capture groups and tidy up
Continued from #1252. This should address the remaining patterns.

@fgsch fgsch force-pushed the fgsch:fgsch/regexp-fixes-3 branch from 4573371 to 1fc6930 Dec 29, 2018

@franbuehler
Copy link
Collaborator

franbuehler left a comment

PR works as advertised!
No logical change within the regex, I reviewed the regex and tested some examples.
Rules are much easier to read now.
Thanks for the PR @fgsch and sorry for my late review :)

@franbuehler

This comment has been minimized.

Copy link
Collaborator

franbuehler commented Jan 10, 2019

Review ok. I'm merging this PR now.

@franbuehler franbuehler merged commit 6f01f9c into SpiderLabs:v3.2/dev Jan 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment