Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
New rule 950140 to detect CGI source code leakages #1275
I like this PR, not tested it yet. Shall I test and merge?
There's precedent for the ERROR severity, most of the response rules (like 950xxx, 953xxx, 954xxx) also use the ERROR severity. It's also documented in
It's not intuitive to me also, and I also see a few response rules with CRITICAL, so maybe we should do another issue to harmonize them all, but let's integrate this PR first.
I know the precedent and wonder what the reasoning might have been. It also leads to 4 being the default outbound anomaly score limit. If we could shift this all to 5, it would be cleaner, I think.
Please go ahead with testing and merging. I'll assign you as reviewer.
Looking at it quickly, I got the feeling it could do with a bit more extensive description, and 1-2 tests.
yes it just looks for
we had in the past 2-3x the situations that the customer did a mistake with a handler or with a mime type declaration...
that's why i made that rule some months ago