Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
wordpress: gutenberg support #1298
Hi @siric1 , I've reviewed your PR, it was almost perfect so I made some very small improvements :)
This PR is ready to be merged AFAIK, however, I would appreciate a look from somebody else to point 2 in my message - Is this ModSec 2/3 discrepancy also your experience? Should we add to our contributions guide to include both variants with and without
(Also, why are unrelated tests failing again?
Yes, I'm using it on 2.x fine with this adaptation @siric1, it's ready in my opinion. Thanks a lot! :)
The test failures on rule 933210 seem to be because our dev branche has already shifted in the meantime (rule 933210 is not yet in this PR), so I'm merging this. @csanders-git feel free to cherrypick this for 3.1.1 release.
Feb 12, 2019
1 check failed
referenced this pull request
Feb 16, 2019
referring to #1309 it seems that the same kind of request could happen on index.php as querystring:
I tried this with
For my issue, but got no joy...