Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression tests. #1350

Closed

Conversation

@studersi
Copy link
Contributor

commented Apr 13, 2019

This pull request fixes/reimplements some of the disabled regression tests and activates them in owasp-modsecurity-crs/util/regression-tests/tests/.

@studersi studersi changed the title Fix regression tests. WIP: Fix regression tests. Apr 13, 2019

@studersi studersi marked this pull request as ready for review Apr 13, 2019

@studersi studersi changed the title WIP: Fix regression tests. Fix regression tests. Apr 13, 2019

@studersi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2019

This is ready to be merged now.

@fgsch

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

Sorry for the delay but could you break down into multiple PRs please?

fgsch added a commit that referenced this pull request Apr 26, 2019

Switch to the latest image for now
This should fix the tests while the old image is reinstated.
Found by many people, including studersi via PR #1350.
@studersi

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

Yes, I can do that. Will do it over the weekend. How should I split them up? One PR per rule that is tested or one PR per test?

@fgsch

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2019

Thank you! One PR per test file would be great.

@studersi

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2019

I created the separate pullrequests for each file. Closing this one.

@studersi studersi closed this May 4, 2019

@fgsch

This comment has been minimized.

Copy link
Collaborator

commented May 4, 2019

Thank you! We'll take a look.

csanders-git pushed a commit to j0k2r/owasp-modsecurity-crs that referenced this pull request May 6, 2019

Switch to the latest image for now
This should fix the tests while the old image is reinstated.
Found by many people, including studersi via PR SpiderLabs#1350.

csanders-git pushed a commit to j0k2r/owasp-modsecurity-crs that referenced this pull request May 6, 2019

Fix indentation
Migrate from python2 to python3
Python 2.7 will not be maintained past 2020

Migrating back to Python2 and abiding by PEP8

Updating whitespace element

Update README.md

add missing OWASP_CRS tags to 921xxx rules

Fix transform name pointed out by secrules_parsing

Whitespace

Add tests for the for command

Ref SpiderLabs#1355

Oneliner test

Revert "Oneliner test"

This reverts commit 7ca2c8e.

Switch to the latest image for now

This should fix the tests while the old image is reinstated.
Found by many people, including studersi via PR SpiderLabs#1350.

Revert back to 2.9-apache-ubuntu for now

Too many things changed in 2-apache and latest is nginx based now.

Added Gobuster

Alphabeticalized gobuster

Adding 21 new positive tests for 942260

Replaced descriptions

added 21 regression tests for rule 942490

Remove regression tests for non-existent rule.

Update regression tests for 931110.

Update regression tests for 931120.

added 36 regression tests for rule 942190

added 36 regression tests for rule 942160

added 16 regression tests for rule 942140

Adding 19 tests for 942150 (none so far)

Adding 14 tests for 942100 (none so far)

added 11 regression tests for rule 942240 (none so far)

Also handle dot variant of X_Filename

PHP will transform dots to underscore in variable names since dot is
invalid.

Content-Type is case insensitive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.