Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
XenForo exclusion profile #1403
Thank you for the PR @lifeforms. It's good to include additional rule exclusion packages.
Some minor issues:
Most rules run in phase 2. I've seen 2-3 running in phase 1. Any particular reason?
If you put everything in the same phase, you are likely to be able to axe one of the initial skipAfter rules.
Rule formatting 9006800
The rule has multiple actions on a single line and the indentation is not consistent.
I do not have a XenForo installation ready, so I can not test. But the PR looks clean and proper to me.
Most exclusions pertain to POST requests, so I've put those in phase 2.
(Could theoretically improve performance by skipping over those rules if we don't have a POST request?)
Only exceptions are the ones which need to run in phase 1:
I'll edit the format of 9006800, thanks.
I realize most of our rule exclusions run in phase 2. But technically, there is no need to wait for phase 2 to exclude a parameter from being processed in phase 2. Or am I wrong?
In my understanding, you manipulating the list of targets of the rule by adding parameters to the ignorelist of said existing rule for the transaction. The existence of the parameter does not matter at all.
With that being said, we could shift all rule exclusions to phase 1 and I do not know why this did not occur to me before.
But there is no need to change your PR more a general idea.
I do not think it is worth to skip over some of the rules if it is not a POST. It complicates the rule set and does not add that much (given there are still 150 CRS rules to execute).
There are now 3 errors in the build:
We maybe overlook the latter one as it is a non-breaking error.
Rebasing should solve the first two. The third one is in your rules.