Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CRS variables configurable #1453

Merged
merged 1 commit into from Jun 15, 2019

Conversation

@franbuehler
Copy link
Collaborator

commented Jun 15, 2019

I applied my changes from my CRS container and made CRS variables configurable (https://hub.docker.com/r/franbuehler/modsecurity-crs-rp).
Tested and built with the files:

  • Dockerfile-2.9-apache
  • Dockerfile-3.0-apache
  • Dockerfile-3.0-nginx

I'll extend the description (README) as soon as you think this PR is fine.

@franbuehler franbuehler requested a review from csanders-git Jun 15, 2019

@franbuehler

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 15, 2019

Test:

docker build -t my-crs . -f Dockerfile-2.9-apache
docker run -dti -p 80:8001    -e PARANOIA=1    -e EXECUTING_PARANOIA=2    -e ENFORCE_BODYPROC_URLENCODED=1    -e ANOMALYIN=10    -e ANOMALYOUT=5    -e ALLOWED_METHODS="GET POST PUT"    -e ALLOWED_REQUEST_CONTENT_TYPE="text/xml|application/xml|text/plain"    -e ALLOWED_REQUEST_CONTENT_TYPE_CHARSET="utf-8|iso-8859-1"    -e ALLOWED_HTTP_VERSIONS="HTTP/1.1 HTTP/2 HTTP/2.0"    -e RESTRICTED_EXTENSIONS=".cmd/ .com/ .config/ .dll/"    -e RESTRICTED_HEADERS="/proxy/ /if/"    -e STATIC_EXTENSIONS="/.jpg/ /.jpeg/ /.png/ /.gif/"    -e MAX_NUM_ARGS=128    -e ARG_NAME_LENGTH=50    -e ARG_LENGTH=200    -e TOTAL_ARG_LENGTH=6400    -e MAX_FILE_SIZE=100000    -e COMBINED_FILE_SIZES=1000000 my-crs
@csanders-git

This comment has been minimized.

Copy link
Collaborator

commented Jun 15, 2019

Amazing!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! (there is not enough time to write out the number of exclamation marks)

@csanders-git

This comment has been minimized.

Copy link
Collaborator

commented Jun 15, 2019

We should also generate a README doc with this for dockerhub.

@csanders-git csanders-git merged commit 623b84a into SpiderLabs:v3.2/dev Jun 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@franbuehler

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 15, 2019

Thank you :-)

I will open a PR for the Dockerhub README.

Is it this one?
https://github.com/SpiderLabs/owasp-modsecurity-crs/blob/v3.2/dev/util/docker/README.md

You could then proofread and correct it, ok?

@csanders-git

This comment has been minimized.

Copy link
Collaborator

commented Jun 15, 2019

yup that is the one -- i will proofread after :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.