New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GPU usage for containers more flexible #674
Make GPU usage for containers more flexible #674
Conversation
@chyumin can you check this? I tried to make the GPU requirement/usage a bit more flexible |
@alejoe91 Yes, I'll take a look. Great idea! |
@alejoe91
What do you think about changing this property name to: gpu_capability with three possible values:
And adapt the rest of the code of course Also it'd be good to warn the user when a sorter is gpu-optional but the flag is enabled when raising the Exception message |
@chyumin thanks for the suggestion! I implemented them, let me know what you think :) |
Co-authored-by: Chuang Yu Min <chg.yumin@gmail.com>
Co-authored-by: Garcia Samuel <sam.garcia.die@gmail.com>
For some sorters (Ironclust, Kilosort1), GPU usage is optional.
This PR allows one to override the default GPU requirements using sorter parameters. Additionally, it checks if an nvidia gpu is available when needed (and if not it throws an interpretable error)