Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse drag in free mode does not update pagination in some cases #810

Closed
2 tasks done
sergotail opened this issue May 25, 2022 · 2 comments
Closed
2 tasks done

Mouse drag in free mode does not update pagination in some cases #810

sergotail opened this issue May 25, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@sergotail
Copy link

Checks

Version

v4.0.2

Description

This is Splide options (i have 15 items 21rem width each):

{
      type: 'slide',
      fixedWidth: '21rem',
      perMove: 1,
      gap: '1.5rem',
      drag: 'free',
      padding: {
          left: '1rem',
          right: '1rem',
      }
}

When i drag list items from second or third to first and pull mouse until first item is fully scrolled, and then release mouse button, pagination dots are not updated. This happens only when i pull mouse even after first item is reached. It seems pagination dots update function checks for condition like "choose dot for which there is an item with x-coordinates [x1, x2] such that viewport left edge is between x1 and x2". But for my case it's possible to not to fit in such condition.

Reproduction Link

No response

Steps to Reproduce

  1. Create splide slider like described above
  2. Pull items with mouse until first item is fully reached and even more
  3. Release mouse button

Expected Behaviour

Pagination dots updated such that current active dot is first

@sergotail sergotail added the bug Something isn't working label May 25, 2022
@sergotail
Copy link
Author

It's also seems that pagination dots update should exec even mouse button wasn't released. Currently, when i drag items with mouse, pagination dots are updated only after mouse button released. It's a quite unconvenient to navigate through big slider with many dots.

@NaotoshiFujita
Copy link
Collaborator

Fixed in the v4.0.6.

It's also seems that pagination dots update should exec even mouse button wasn't released.

This is a new feature. Currently, there is no plan to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants