Implement XML text format#58
Closed
zml2008 wants to merge 1 commit into
Closed
Conversation
zml2008
force-pushed
the
feature/xmltext
branch
2 times, most recently
from
9206304 to
b4f007b
Compare
Contributor
There was a problem hiding this comment.
I think that these miniature classes (A, B, I, ...) could be contained within a class Elements as public static classes because they are too small IMO for a separate class each.
Includes impl updates necessary to handle TextRepresentation API changes Most of the implementation provided by @TomyLobo and adapted for Sponge
Malachiel87
referenced
this pull request
Feb 3, 2021
- Silence spam for unknown slots or inventory states, now goes to debug Signed-off-by: Chris Sanders <zidane@spongepowered.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of XML text format, mostly provided by TomyLobo
Remaining implementation issues