Switch from using ListenableFuture to CompletableFuture #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompletableFuture is the jdk8 equivalent of guava's ListenableFuture class, with similar capabilities but better lambda integration.
|
@zml2008 what would the equivalent of this be using |
|
@kashike probably something like https://gist.github.com/anonymous/89f6c2093204bc82c40a -- untested, you'd have to mess around a bit. |
zml2008
added a commit
that referenced
this pull request
Feb 28, 2016
CompletableFuture is the jdk8 equivalent of guava's ListenableFuture class, with similar capabilities but better lambda integration. Closes #1058
windy1
pushed a commit
that referenced
this pull request
Feb 28, 2016
CompletableFuture is the jdk8 equivalent of guava's ListenableFuture class, with similar capabilities but better lambda integration. Closes #1058
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI PR | SpongeCommon PR
CompletableFuture is the jdk8 equivalent of guava's ListenableFuture
class, with similar capabilities but better lambda integration.
There shouldn't be any reason to prefer guava classes over java classes, but this PR is here in case anyone wants to discuss that.