[API8] Add datapack support by mattmess1221 · Pull Request #1706 · SpongePowered/SpongeAPI

mattmess1221 · 2017-11-28T06:22:29Z

I'm assuming the client's resource manager was reused for the server. Likely more edits will come when I have access to deobfuscated code.

liach · 2017-11-29T05:11:04Z

should we merge resource path with catalog key?

mattmess1221 · 2017-11-29T05:15:24Z

If we do, we should settle on a better suited name. It doesn't make sense to get a Resource from a CatalogKey, and neither does a CatalogType with ResourcePath

Though they are slightly different. While both have a namespace and value, the resource path can contain a forward slash / and dot .. If anything, it should have a common parent-interface indicating it can have a namespace.

liach · 2017-11-29T05:29:45Z

Something like BinomialName for a parent interface?

mattmess1221 · 2017-11-29T05:32:23Z

I was thinking it would include the word namespace. Something like NamespacedIdentifier

liach · 2017-11-29T06:04:50Z

SpacedName

ryantheleach · 2018-01-04T04:27:49Z

I don't like that this outright deprecates the Asset API.

The goals of the Asset API were to simplify the process for new programmers to extract resources from their jar files, to their plugin directories on disk, usually used for extracting default or example configurations.

If this is to happen, I'd like at least a little attention paid to giving those people a clear migration path, and maybe some docs to go along with it to explain exactly what this is and how it works.

I also think the name DataPack is pretty close to the Mojang defined term.

If this isn't intended to be directly compatible with that, or interact with that in some way then it's poorly named.

But maybe I'm just not following why the name change is needed?

Cybermaxke · 2018-01-05T21:54:13Z

Please keep the ResourcePath separate from the CatalogId. They represent two different things and shouldn't be merged as one. They also have different contraints.

Cybermaxke · 2018-01-05T22:06:56Z

    String getPath();

+    @Override
+    int hashCode();


Why is this in the API?

For arbitrary order?

I put it there originally because I wanted it to be clear that this can be used in a Map. Now I'm just saying so in the docs.

…s to load

I'm still working on figuring out how ResourcePackList works.

but the PackInfo cannot be gotten back from the pack. Temp remove ResourceId until I can figure out a good way to use it. Remove the try-with-resources from Resource. It should be done from the caller.

Also some javadocs

Adds async reloaders Tweak some method names Remove some less useful methods TODO: Javadocs

Zidane · 2020-06-28T04:26:08Z

@killjoy1221 Need this finished up soon else it won't make it for API 8.0.0

mattmess1221 · 2020-06-28T22:11:18Z

#2135

kashike added status: input wanted status: needs review api: 8 (u) version: 1.16 (unsupported since Oct 17th 2023) labels Nov 28, 2017

kashike suggested changes Nov 29, 2017

View reviewed changes

Comment thread src/main/java/org/spongepowered/api/Game.java Outdated

kashike force-pushed the 1.13 branch from fdc5328 to d7f2e69 Compare December 8, 2017 20:41

kashike force-pushed the 1.13 branch from d7f2e69 to 8277fda Compare January 3, 2018 12:17

ryantheleach reviewed Jan 4, 2018

View reviewed changes

Comment thread src/main/java/org/spongepowered/api/resource/Resource.java Outdated

mattmess1221 force-pushed the feature/packs branch from c49bf87 to d8a70e8 Compare January 4, 2018 04:35

liach reviewed Jan 4, 2018

View reviewed changes

Cybermaxke reviewed Jan 5, 2018

View reviewed changes

Comment thread src/main/java/org/spongepowered/api/resource/Pack.java Outdated

Cybermaxke reviewed Jan 5, 2018

View reviewed changes

Comment thread src/main/java/org/spongepowered/api/resource/ResourceManager.java Outdated

Cybermaxke reviewed Jan 5, 2018

View reviewed changes

Comment thread src/main/java/org/spongepowered/api/resource/ResourceManager.java Outdated

Cybermaxke reviewed Jan 5, 2018

View reviewed changes

mattmess1221 force-pushed the feature/packs branch from 5f9b085 to adfe438 Compare January 5, 2018 22:17

Cybermaxke reviewed Jan 6, 2018

View reviewed changes

Comment thread src/main/java/org/spongepowered/api/resource/ResourceProvider.java

Cybermaxke reviewed Jan 6, 2018

View reviewed changes

Comment thread src/main/java/org/spongepowered/api/resource/PackProvider.java Outdated

Cybermaxke reviewed Jan 6, 2018

View reviewed changes

Comment thread src/main/java/org/spongepowered/api/resource/ResourcePath.java Outdated

liach reviewed Jan 6, 2018

View reviewed changes

Comment thread src/main/java/org/spongepowered/api/resource/ResourceId.java Outdated

Cybermaxke reviewed Jan 6, 2018

View reviewed changes

Comment thread src/main/java/org/spongepowered/api/event/resource/ResourceReloadEvent.java Outdated

Cybermaxke mentioned this pull request Jan 6, 2018

Minecraft 1.13 - Datapacks LanternPowered/Lantern#53

Open

stephan-gh reviewed Jan 6, 2018

View reviewed changes

Comment thread src/main/java/org/spongepowered/api/resource/Resource.java Outdated

mattmess1221 force-pushed the feature/packs branch 2 times, most recently from 4a4e07c to 1ad90b3 Compare January 8, 2018 03:20

mattmess1221 added 21 commits June 18, 2019 01:40

Resource.getReader now returns a BufferedReader

8e0fc0e

ResourcePath is iterable on it's parents

cb2f431

Fixup some javadoc

2efe859

Add some filename related methods

84a1b55

Add some methods to ResourceReloadEvent.Pre for manipulating the pack…

aa40cf5

…s to load

Add a method in Pack.Builder for providing from a file

425b94e

Rework the resource system to be more inline with vanilla.

12cc2f6

I'm still working on figuring out how ResourcePackList works.

Add a PackRepository and PackInfo. The PackInfo is used to get the Pack,

abd3024

but the PackInfo cannot be gotten back from the pack. Temp remove ResourceId until I can figure out a good way to use it. Remove the try-with-resources from Resource. It should be done from the caller.

Update some javadocs and modify a few methods

58020b5

Add resourcetype argument to PluginContainer.getPack()

0cf1c83

Also some javadocs

Change for 1.14

2a78632

Adds async reloaders Tweak some method names Remove some less useful methods TODO: Javadocs

Fix the build

30fe7de

Fix some rebase artifacts

1052aab

AsyncReloader had too much impl.

84cf0d9

Pack should be closeable.

309d66e

Fixes to javadocs and nitpicks

d6dc2a0

Change PackTypes.ASSETS to RESOURCES

a47186a

Remove the assets package.

b124bb8

Fix some nitpicks

f540f2b

Remove WillNotClose from Resource copy.

fcfb76c

Change getInputStream javadoc to represent current code.

b195b1d

mattmess1221 force-pushed the feature/packs branch from 74c58d2 to b195b1d Compare June 18, 2019 05:42

gabizou force-pushed the api-8 branch from 059ca03 to 068a97b Compare October 13, 2019 03:15

Zidane force-pushed the api-8 branch from 1516994 to 044069b Compare November 29, 2019 05:27

Zidane removed the branch: bleeding label Jun 28, 2020

gabizou force-pushed the api-8 branch from 7509f39 to 9b1cc75 Compare June 28, 2020 21:54

mattmess1221 mentioned this pull request Jun 28, 2020

[API-8] Resource Management #2135

Closed

mattmess1221 closed this Jun 28, 2020

Uh oh!

Conversation

mattmess1221 commented Nov 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liach commented Nov 29, 2017

Uh oh!

mattmess1221 commented Nov 29, 2017

Uh oh!

liach commented Nov 29, 2017

Uh oh!

mattmess1221 commented Nov 29, 2017

Uh oh!

liach commented Nov 29, 2017

Uh oh!

Uh oh!

ryantheleach commented Jan 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Cybermaxke commented Jan 5, 2018

Uh oh!

Uh oh!

Uh oh!

Cybermaxke Jan 5, 2018

Choose a reason for hiding this comment

Uh oh!

liach Jan 5, 2018

Choose a reason for hiding this comment

Uh oh!

mattmess1221 Jan 5, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zidane commented Jun 28, 2020

Uh oh!

mattmess1221 commented Jun 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mattmess1221 commented Nov 28, 2017 •

edited

Loading

ryantheleach commented Jan 4, 2018 •

edited

Loading