Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizardry In-World Fluid Crafting Not Working #2795

Open
Aiidoneus opened this issue Jun 3, 2019 · 7 comments

Comments

@Aiidoneus
Copy link

commented Jun 3, 2019

  • SpongeForge version: spongeforge-1.12.2-2825-7.1.6-RC3749.jar

  • Forge version: forge-1.12.2-14.23.5.2837-universal.jar

  • Java version: 8

  • Operating System: Ubuntu

  • Plugins/Mods:

Issue Description
It seems that the in-world fluid crafting seems to be broken with sponge. Tested this without sponge on a server and it works as intended. How the crafting works is you place mana in the world and drop a gold nugget into the pool. It then produces particles then after a few seconds, transforms into Nacre. With Sponge installed, it produces the particles but never transforms. I tested this with just Wizardry installed by itself and on FTB Interactions with the results being the same. This is a fairly big issue on FTB Interaction servers.
The crafting recipe: https://imgur.com/a/YvJI0vM
Let me know if you need further info.
-Aidoneus

@phit

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

confirmed with
Forgelin-1.8.3.jar
librarianlib-1.12.2-4.19.2-release.jar
wizardry-0.10.8.jar
spongeforge-1.12.2-2838-7.1.7-RC3807.jar

@phit phit moved this from todo to tested/closed in phit's eternal cleanup Jun 22, 2019

@gabizou

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

Can you give 7.1.7-RC3820 a shot? I'm almost sure that it ends up fixing the issue (was using the wrong entity to force spawn to the world).

@phit

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

still an issue with 3820

Recommended Build 7.1.7 automation moved this from Blocking Issues to Done Jun 25, 2019

gabizou added a commit that referenced this issue Jun 25, 2019

Fix issue with custom item entities. Fixes #2795.
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

@phit phit reopened this Jun 29, 2019

Recommended Build 7.1.7 automation moved this from Done to Blocking Issues Jun 29, 2019

@phit

This comment has been minimized.

Copy link
Member

commented Jun 29, 2019

doesn't work in 1.12.2-2838-7.1.7-RC3832

@phit

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

crafttweaker script to add replacement recipes for FTB Interactions to bypass this issue temporarily

import crafttweaker.item.IItemStack;
import crafttweaker.item.IIngredient;

val manaBucket = <forge:bucketfilled>.withTag({FluidName: "mana_fluid", Amount: 1000}).onlyWithTag({FluidName: "mana_fluid", Amount: 1000});
recipes.addShapeless(<forge:bucketfilled>.withTag({FluidName: "nacre_fluid", Amount: 1000}) * 1, [<ore:nuggetGold> * 1,manaBucket.noReturn() * 1]);
recipes.addShapeless(<wizardry:wisdom_wood_log> * 1, [manaBucket.reuse() * 1,<ore:logWood> * 1]);
recipes.addShapeless(<wizardry:wisdom_stick> * 1, [manaBucket.reuse() * 1,<ore:stickWood> * 1]);
recipes.addShapeless(<wizardry:wisdom_sapling> * 1, [manaBucket.reuse() * 1,<ore:treeSapling> * 1]);
recipes.addShapeless(<wizardry:orb:1> * 1, [manaBucket.reuse() * 1,<wizardry:orb> * 1]);
@Zoneman1972

This comment has been minimized.

Copy link

commented Jul 13, 2019

Please excuse my ignorance guys, I'm still fairly new to this scripting business, but would you mind dumbing this down for me please?
Where exactly does this script go?
Is it a separate script of its own or does it get added into an existing one?
If so, which script does it get added to? FTBCustom or Wizardry?

If I'm way off the track, could you please steer me back in to the right direction.
Thanks in advance for any assistance you can provide

@phit

This comment has been minimized.

Copy link
Member

commented Jul 13, 2019

just make a new file in the scripts folder, name it literallyanyname.zs and paste what I posted in there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.