This repository has been archived by the owner on Nov 25, 2020. It is now read-only.
feat(project): add items bindable #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bas080
force-pushed
the
feat/items-bindable
branch
from
494a077
to
250d4f2
Compare
RWOverdijk
suggested changes
Dec 23, 2016
| @@ -74,6 +72,9 @@ export class AutoCompleteCustomElement { | |||
| return logger.error('auto complete requires resource or items bindable to be defined'); | |||
| } | |||
|
|
|||
| this.search = this.label(this.value); | |||
| this.justSelected = true; | |||
| @@ -131,14 +132,21 @@ export class AutoCompleteCustomElement { | |||
| } | |||
|
|
|||
| /** | |||
| * returns HTML that wraps matching substrings with strong tags | |||
| * returns HTML that wraps matching substrings with strong tags. If not | |||
There was a problem hiding this comment.
Cut on new sentence or append on the end.
| let openDropdown = (show = true) => { | ||
| this.showResults = show; | ||
| }; | ||
| this.dropdownElement = this.element.querySelectorAll('.dropdown.open')[0]; |
There was a problem hiding this comment.
Because bootstrap.js will add and remove the open class for you
bas080
force-pushed
the
feat/items-bindable
branch
from
d994806
to
c5a7862
Compare
RWOverdijk
suggested changes
Jan 3, 2017
| if (this.limit) { | ||
| query.limit = this.limit; | ||
| } | ||
|
|
||
| return query; | ||
| } | ||
| } | ||
|
|
| } | ||
|
|
||
| return this.findResults(this.searchQuery(this.search)).then(results => { | ||
| let promise = this.findResults(this.searchQuery(this.search)).then(results => { |
There was a problem hiding this comment.
Why not use: this.lastFindPromise = ....?
It's a sync process as far as I can see, so the assignment is basically the same, isn't it?
This enables users to use and array with values to auto-complete on. When using this bindable it disables the performing of requests. Once noticable change is that an empty string will trigger a new search/filter when the input receives focus. Contains the necessary documentation which explains what methods can be overwritten and the newly defined items bindable. Also updated the altered bindables behavior documentation
…instance with replace method
bas080
force-pushed
the
feat/items-bindable
branch
from
c5a7862
to
aacbcf6
Compare
|
@VMBindraban and @jeremyvergnas please review. |
| } | ||
|
|
||
| this.lastFindPromise = this.findResults(this.searchQuery(this.search)).then(results => { | ||
| if (this.lastFindPromise !== promise) { |
There was a problem hiding this comment.
Can be removed I guess
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users to use and array with values to auto-complete on. When using
this bindable it disables the performing of requests.
Contains the necessary documentation which explains what methods can be
overwritten and the newly defined items bindable. Also updated the altered
bindables behavior documentation