Skip to content
This repository has been archived by the owner on Nov 25, 2020. It is now read-only.

fix(entity): do not delete id from request body in update calls #268

Merged
merged 5 commits into from Feb 15, 2017
Merged

fix(entity): do not delete id from request body in update calls #268

merged 5 commits into from Feb 15, 2017

Conversation

CuddleBunny
Copy link

Note: Didn't have permission to push the branch to the main project so I forked it.

@RWOverdijk
Copy link
Member

@CuddleBunny That's exactly how it should be done :)

Would you mind changing your commit message according to our contributing guidelines? This includes the "breaking change" part.

Previous functionality unnecessarily limited common alternative API conventions.

BREAKING CHANGE: id properties are now included in the request body of update calls. Fixes #185.
@CuddleBunny CuddleBunny changed the title fixes #185 fix(entity): do not delete id from request body in update calls Feb 7, 2017
@RWOverdijk
Copy link
Member

Not exactly what I had in mind, your other commits are still there. But it's alright, I'll merge it later today.

@CuddleBunny
Copy link
Author

Hmm, not sure why that happened. My local repository doesn't have all of that. I've not used GitHub a whole lot.

@RWOverdijk RWOverdijk merged commit fafaf36 into SpoonX:master Feb 15, 2017
@RWOverdijk
Copy link
Member

@CuddleBunny Published in a pre-release 5.0.0-1. If this works for the updaters, it will be released as stable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants