Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files
fix(config): prevent unwanted garbage collection
unfortunatelly, how, why that is happening, i don't still know. but using Object.create at that point cause 'namespace' to get garbage collected which leads to missing defaults when overwriting a namespace setting later.
  • Loading branch information
doktordirk committed Aug 5, 2016
1 parent 6b89858 commit 3d38d6f874e43354b2e7d4a6b29e7874631bae6d
Showing with 3 additions and 4 deletions.
  1. +3 −4 src/config.js
@@ -40,11 +40,10 @@ export class Config {
* @returns {Config}
*/
configureNamespace(name, configs = {map: {}}) {
let namespace = Object.create(this.fetch(name));
let config = {[name]: namespace};

let namespace = this.fetch(name);
extend(true, namespace, configs);
this.configure(config);

this.configure({[name]: namespace});

return this;
}

0 comments on commit 3d38d6f

Please sign in to comment.