Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config deserializer crate #234

Closed
wants to merge 7 commits into from
Closed

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented Jul 16, 2022

Issue number and link

Fixes: #220
Recreate for #216

Describe your changes

  • add springql-deconfig (DEserialize CONFIGuration )
  • move toml deserialize to springql-deconfig
  • remove Default for SpringConfig
  • fix affected tests

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

Cargo.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Base: 84.11% // Head: 84.17% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (dd67f77) compared to base (92abd52).
Patch coverage: 98.38% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   84.11%   84.17%   +0.05%     
==========================================
  Files         219      220       +1     
  Lines       12789    12854      +65     
==========================================
+ Hits        10758    10820      +62     
- Misses       2031     2034       +3     
Impacted Files Coverage Δ
springql-configloader/src/lib.rs 95.00% <95.00%> (ø)
springql-core/src/api/spring_config.rs 100.00% <100.00%> (+14.70%) ⬆️
springql-core/src/pipeline/test_support/fixture.rs 86.26% <100.00%> (+3.94%) ⬆️
springql/tests/e2e_connect_2_pipelines.rs 100.00% <100.00%> (ø)
springql/tests/e2e_high_level_rs.rs 100.00% <100.00%> (ø)
springql/tests/e2e_sampling.rs 100.00% <100.00%> (ø)
springql/tests/feat_aggregation.rs 100.00% <100.00%> (ø)
springql/tests/feat_join.rs 100.00% <100.00%> (ø)
springql/tests/feat_logical_ops.rs 100.00% <100.00%> (ø)
springql/tests/feat_numerical_ops.rs 100.00% <100.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kazuk kazuk requested a review from laysakura September 1, 2022 23:43
Copy link
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazuk Could you check this patch?

This is nearly what I said in the previous comment.

This patch reduces lots of WET codes.
However, springql-core depends on TOML library, which is the very reason of your work.

So could you consider making toml feature in springql-configloader crate, as I said in the previous comment?

@kazuk kazuk closed this Sep 24, 2022
@laysakura laysakura reopened this Oct 7, 2022
@laysakura
Copy link
Contributor

I'll take over this PR.

@laysakura laysakura self-assigned this Oct 7, 2022
@kazuk kazuk closed this Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configuration deserialize feature not need in core
2 participants