Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SELECT with aggregate preserves select_list order #128

Merged
merged 7 commits into from May 11, 2022

Conversation

laysakura
Copy link
Contributor

@laysakura laysakura commented May 11, 2022

fixes: #50

@laysakura laysakura changed the title fix: SELECT with aggragate preserves select_list order fix: SELECT with aggregate preserves select_list order May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #128 (f124810) into main (74ad08b) will increase coverage by 0.21%.
The diff coverage is 98.69%.

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   87.08%   87.29%   +0.21%     
==========================================
  Files         201      201              
  Lines       11944    12104     +160     
==========================================
+ Hits        10401    10566     +165     
+ Misses       1543     1538       -5     
Impacted Files Coverage Δ
springql-core/src/expr_resolver/expr_label.rs 92.85% <0.00%> (-7.15%) ⬇️
springql-core/src/pipeline/field.rs 100.00% <ø> (ø)
...rc/stream_engine/autonomous_executor/task/tuple.rs 100.00% <ø> (ø)
..._engine/command/query_plan/query_plan_operation.rs 100.00% <ø> (ø)
...k/pump_subtask/query_subtask/projection_subtask.rs 94.44% <94.44%> (ø)
springql-core/src/expr_resolver.rs 88.67% <95.83%> (-0.90%) ⬇️
...am_engine/autonomous_executor/task/window/panes.rs 98.03% <96.87%> (-0.45%) ⬇️
...ngine/autonomous_executor/task/window/aggregate.rs 98.02% <99.43%> (+1.86%) ⬆️
springql-core/src/sql_processor/query_planner.rs 95.00% <100.00%> (+0.47%) ⬆️
...cutor/task/pump_task/pump_subtask/query_subtask.rs 95.85% <100.00%> (+0.20%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ad08b...f124810. Read the comment docs.

@laysakura laysakura force-pushed the fix/select_list-order-with-aggr branch from 5a7b7f3 to f124810 Compare May 11, 2022
@laysakura laysakura merged commit cccad2d into main May 11, 2022
14 of 15 checks passed
@laysakura laysakura deleted the fix/select_list-order-with-aggr branch May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant