Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic on aggregate without GROUP BY clause #129

Merged
merged 5 commits into from May 11, 2022

Conversation

laysakura
Copy link
Contributor

@laysakura laysakura commented May 11, 2022

fixes: #126

Also, GROUP BY clause gets to take multiple elements.

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #129 (37b2536) into main (cccad2d) will increase coverage by 0.13%.
The diff coverage is 97.52%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   87.30%   87.43%   +0.13%     
==========================================
  Files         201      202       +1     
  Lines       12104    12259     +155     
==========================================
+ Hits        10567    10719     +152     
- Misses       1537     1540       +3     
Impacted Files Coverage Δ
.../pipeline/pump_model/window_operation_parameter.rs 100.00% <ø> (ø)
...ringql-core/src/sql_processor/sql_parser/syntax.rs 50.00% <ø> (ø)
springql-core/src/sql_processor/query_planner.rs 95.18% <82.35%> (+0.18%) ⬆️
...e/src/sql_processor/sql_parser/pest_parser_impl.rs 87.72% <92.85%> (+0.09%) ⬆️
..._executor/task/window/panes/pane/aggregate_pane.rs 95.72% <97.72%> (+1.28%) ⬆️
...pump_model/window_operation_parameter/aggregate.rs 100.00% <100.00%> (ø)
..._planner/select_syntax_analyzer/group_aggregate.rs 100.00% <100.00%> (ø)
...ngine/autonomous_executor/task/window/aggregate.rs 98.02% <100.00%> (ø)
...am_engine/autonomous_executor/task/window/panes.rs 98.05% <100.00%> (+0.01%) ⬆️
springql-core/tests/feat_aggregation.rs 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cccad2d...37b2536. Read the comment docs.

@laysakura laysakura merged commit 9c5a9cc into main May 11, 2022
14 of 15 checks passed
@laysakura laysakura deleted the fix/aggregation-without-group branch May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant