Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix actionlint warnings #150

Merged
merged 3 commits into from May 19, 2022
Merged

ci: fix actionlint warnings #150

merged 3 commits into from May 19, 2022

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented May 18, 2022

Issue number and link

Fixes: #151

Describe your changes

  • fix shellcheck reported issue
    • SC2086: Double quote to prevent globbing and word splitting
    • SC2043: This loop will only ever run once. Bad quoting or missing glob/expansion?
  • add actionlint task to Makefile.toml

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #150 (9eb696a) into main (16dacb0) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   87.81%   87.82%           
=======================================
  Files         203      203           
  Lines       12620    12620           
=======================================
+ Hits        11082    11083    +1     
+ Misses       1538     1537    -1     
Impacted Files Coverage Δ
...ngql-core/src/stream_engine/autonomous_executor.rs 93.90% <0.00%> (-1.22%) ⬇️
springql-core/src/expression.rs 75.44% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16dacb0...9eb696a. Read the comment docs.

@kazuk kazuk marked this pull request as ready for review May 18, 2022
@kazuk kazuk requested a review from laysakura May 18, 2022
@kazuk kazuk changed the title fix actionlint warnings ci: fix actionlint warnings May 18, 2022
Copy link
Contributor

@laysakura laysakura left a comment

Why don't you run actionlint task in CI?

(docker-in-docker issues?)

CHANGELOG.md Outdated Show resolved Hide resolved
@kazuk
Copy link
Contributor Author

kazuk commented May 19, 2022

Why don't you run actionlint task in CI?

I think the time when CI maintenance will occur frequently is about to end.

If the CI processing corrections occur frequently in the future, there is a benefit to add, but if it occurs very rarely, I think that it is not necessary to run it every time.

If we need a drastic correction of CI processing, we can consider adding it before doing it.

@kazuk kazuk requested a review from laysakura May 19, 2022
Copy link
Contributor

@laysakura laysakura left a comment

🙏

@laysakura laysakura merged commit 8b2cbf8 into main May 19, 2022
15 of 16 checks passed
@laysakura laysakura deleted the lint_github_actions branch May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants