Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add copy of examples to lib.md #156

Merged
merged 2 commits into from May 30, 2022
Merged

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented May 21, 2022

Issue number and link

Fixes: #105

Describe your changes

add document code copy from examples.

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #156 (5a24bd2) into main (8b2cbf8) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   87.79%   87.82%   +0.02%     
==========================================
  Files         203      203              
  Lines       12620    12620              
==========================================
+ Hits        11080    11083       +3     
+ Misses       1540     1537       -3     
Impacted Files Coverage Δ
..._engine/autonomous_executor/row/value/sql_value.rs 75.51% <0.00%> (+0.68%) ⬆️
springql-core/src/expression.rs 75.44% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2cbf8...5a24bd2. Read the comment docs.

@kazuk kazuk requested a review from laysakura May 28, 2022
Copy link
Contributor

@laysakura laysakura left a comment

🙌

@laysakura laysakura merged commit e1d63b7 into main May 30, 2022
15 of 16 checks passed
@laysakura laysakura deleted the add_code_example_to_docs branch May 30, 2022
@laysakura laysakura mentioned this pull request May 31, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants