Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: release script #215

Merged
merged 8 commits into from
Jul 9, 2022
Merged

ci: release script #215

merged 8 commits into from
Jul 9, 2022

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented Jun 26, 2022

Issue number and link

Relates: #66

Describe your changes

  • add bash script for edit CHANGELOG
  • add bumping crate versions
  • publish crates
  • git tagging and push

currently disable for any update to git and crates.io , so we need test for flow is collect.

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #215 (6ff5db1) into main (a9e22fd) will decrease coverage by 0.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   84.85%   83.92%   -0.93%     
==========================================
  Files         215      218       +3     
  Lines       12545    12743     +198     
==========================================
+ Hits        10645    10695      +50     
- Misses       1900     2048     +148     
Impacted Files Coverage Δ
springql-core/src/pipeline/option.rs 50.00% <0.00%> (-16.67%) ⬇️
.../task/sink_task/sink_writer/sink_writer_factory.rs 84.61% <0.00%> (-15.39%) ⬇️
...engine/autonomous_executor/test_support/factory.rs 75.00% <0.00%> (-15.00%) ⬇️
springql-core/src/pipeline/relation/sql_type.rs 72.09% <0.00%> (-9.31%) ⬇️
...ous_executor/task/source_task/source_reader/can.rs 23.37% <0.00%> (-3.79%) ⬇️
springql-core/src/pipeline/test_support/fixture.rs 82.32% <0.00%> (-3.61%) ⬇️
springql-core/src/pipeline/name.rs 51.76% <0.00%> (-3.53%) ⬇️
...onomous_executor/task/sink_task/sink_writer/net.rs 86.45% <0.00%> (-3.43%) ⬇️
...src/pipeline/sink_writer_model/sink_writer_type.rs 14.28% <0.00%> (-2.39%) ⬇️
...tream_engine/autonomous_executor/row/stream_row.rs 94.82% <0.00%> (-1.26%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e22fd...6ff5db1. Read the comment docs.

@kazuk kazuk changed the title WIP: ci: release script ci: release script Jun 28, 2022
@kazuk kazuk marked this pull request as ready for review June 29, 2022 03:41
@kazuk kazuk requested a review from laysakura June 29, 2022 03:41
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
if [ "$line" == "## [Unreleased]" ]; then
# insert line after ## [Unleleased]
echo # output blank line
echo "## [${NEW_VERSION}]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From v0.14.0, we started to add the release date here.

https://github.com/SpringQL/SpringQL/blob/main/CHANGELOG.md#v0140---2022-06-24

Could you add the date automatically from system clock? (either UTC or JST would be OK)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. How about this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do it with minor change.
I want tests whole release workflow first.

@laysakura laysakura self-requested a review July 8, 2022 04:08
laysakura
laysakura previously approved these changes Jul 8, 2022
Copy link
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. You can merge this to try the workflow execution if you will do something for the comment later.

.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@laysakura
Copy link
Contributor

laysakura commented Jul 8, 2022

lint & lcov job is already fixed in the main branch.

Copy link
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge it for checking the workflow but I added a comment.

if [ "$line" == "## [Unreleased]" ]; then
# insert line after ## [Unleleased]
echo # output blank line
echo "## [${NEW_VERSION}]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. How about this?

@laysakura laysakura merged commit c4a8fef into main Jul 9, 2022
@laysakura laysakura deleted the ci_release_job branch July 9, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants