Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: window task's ProcessedRow was zero when no pane is closed #235

merged 2 commits into from Aug 3, 2022


Copy link

@laysakura laysakura commented Aug 3, 2022

Issue number and link

Fixes: #236

Describe your changes

  • Change the logic to calculate ProcessingRows for window tasks.

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@laysakura laysakura marked this pull request as ready for review August 3, 2022 09:53
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #235 (270a69e) into main (f7893c2) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #235      +/-   ##
+ Coverage   84.08%   84.11%   +0.03%     
  Files         219      219              
  Lines       12779    12789      +10     
+ Hits        10745    10758      +13     
+ Misses       2034     2031       -3     
Impacted Files Coverage Δ
...cutor/task/pump_task/pump_subtask/ 96.98% <100.00%> (+0.15%) ⬆️
...e/src/sql_processor/sql_parser/ 87.95% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7893c2...270a69e. Read the comment docs.

Copy link
Contributor Author

check-dependencies will be fixed in #237

@laysakura laysakura merged commit 37256b4 into main Aug 3, 2022
@laysakura laysakura deleted the fix/window-task-ProcessedRow branch August 3, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Window tasks got too slow
1 participant