Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Minnimum Supported Rust Version to 1.63 #241

Merged
merged 4 commits into from
Oct 7, 2022
Merged

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented Sep 6, 2022

Issue number and link

Fixes: #240

Describe your changes

Bump MRSV to 1.63

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Base: 84.04% // Head: 83.96% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (ebcb2c9) compared to base (17b2866).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   84.04%   83.96%   -0.08%     
==========================================
  Files         219      219              
  Lines       12789    12789              
==========================================
- Hits        10748    10738      -10     
- Misses       2041     2051      +10     
Impacted Files Coverage Δ
...ql_processor/sql_parser/pest_parser_impl/helper.rs 78.57% <0.00%> (-14.29%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@laysakura laysakura merged commit 9959139 into main Oct 7, 2022
@laysakura laysakura deleted the bump_mrsv_1.63 branch October 7, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

time crate requires Rust 1.59.0+
2 participants