refactor ContextLoaderUtils class

[ttddyy]

In ContextLoaderUtils class, these two methods contain similar loop logic

• resolveContextLoaderClass(Class<?>, String)
• resolveContextConfigurationAttributes(Class<?>)

Created a private method that returns a list of ContextConfigurationAttribute, and changed above two methods to use the new one to clean up the duplicated logic.

Further cleanup suggestion:

"resolveContextConfigurationAttributes(Class<?> clazz)" method returns "List< ContextConfigurationAttributes>", and the returned list has parent-class-first order.
On the other hand, the caller of the method, "buildMergedContextConfiguration(...)", uses the list in reverse order: child class first.
So, it would be easier to read if "resolveContextConfigurationAttributes" method returns the list as child-first order.
This method has unit tests in ContextLoaderUtilsTests, so they need to be updated as well.

---

Issue: SPR-9918

I have signed and agree to the terms of the SpringSource Individual
Contributor License Agreement.

[sbrannen]

Tadaya,

Thanks for pointing this out and submitting the pull request!

In order to simplify the code and remain consistent with the conventions currently in use in the class, I have chosen to address this issue differently than in your pull request. Please check out commit 33d5b01 for details.

Cheers,

Sam