INT-2920 Fix two hits to MessageStore#736
Closed
nickspacek wants to merge 3 commits into
Closed
Conversation
Reduce ClaimCheckOutTransformer's hits to the MessageStore. JIRA: https://jira.springsource.org/browse/INT-2920
Contributor
|
Thanks for issuing the pull request! One "minor" detail... it doesn't compile ;) I can fix that, but it would be great if you re-issue. Also, if you don't mind updating the copyright range to 2013, and add an @ author tag. For future reference (we do hope you issue more PRs!), the info here can be helpful for walking thru the steps (like running the build and tests pre-push, etc): https://github.com/SpringSource/spring-integration/wiki/Contributor-Guidelines |
Contributor
Author
|
That's embarrassing, I will admit I skipped the build and test, yikes. I will make the changes! |
Contributor
Author
|
I don't think this is related to my fix, but when I run the tests I get 1 failure: |
Contributor
|
LGTM; merging. |
garyrussell
added a commit
to garyrussell/spring-integration
that referenced
this pull request
Feb 8, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce ClaimCheckOutTransformer's hits to the MessageStore.
JIRA: https://jira.springsource.org/browse/INT-2920