Skip to content

INT-2920 Fix two hits to MessageStore#736

Closed
nickspacek wants to merge 3 commits into
spring-projects:masterfrom
nickspacek:INT-2920
Closed

INT-2920 Fix two hits to MessageStore#736
nickspacek wants to merge 3 commits into
spring-projects:masterfrom
nickspacek:INT-2920

Conversation

@nickspacek

Copy link
Copy Markdown
Contributor

Reduce ClaimCheckOutTransformer's hits to the MessageStore.

JIRA: https://jira.springsource.org/browse/INT-2920

Reduce ClaimCheckOutTransformer's hits to the MessageStore.

JIRA: https://jira.springsource.org/browse/INT-2920
@ghost ghost assigned markfisher Feb 6, 2013
@markfisher

Copy link
Copy Markdown
Contributor

Thanks for issuing the pull request! One "minor" detail... it doesn't compile ;)

spring-integration/spring-integration-core/src/main/java/org/springframework/integration/transformer/ClaimCheckOutTransformer.java:70: ';' expected
                + " within MessageStore [" + this.messageStore + "]")
                                                                     ^
1 error
:spring-integration-core:compileJava FAILED

I can fix that, but it would be great if you re-issue. Also, if you don't mind updating the copyright range to 2013, and add an @ author tag.

For future reference (we do hope you issue more PRs!), the info here can be helpful for walking thru the steps (like running the build and tests pre-push, etc): https://github.com/SpringSource/spring-integration/wiki/Contributor-Guidelines

@nickspacek

Copy link
Copy Markdown
Contributor Author

That's embarrassing, I will admit I skipped the build and test, yikes. I will make the changes!

@nickspacek

Copy link
Copy Markdown
Contributor Author

I don't think this is related to my fix, but when I run the tests I get 1 failure:

org.springframework.integration.core.AsyncMessagingTemplateTests > executionException
FAILED
    java.lang.Exception
        Caused by: java.util.concurrent.TimeoutException at AsyncMessagingTemplateTests.java:409

@garyrussell

Copy link
Copy Markdown
Contributor

LGTM; merging.

garyrussell added a commit to garyrussell/spring-integration that referenced this pull request Feb 8, 2013
@garyrussell garyrussell closed this Feb 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants