update tweet object to expose retweeted status, profile, and entities#17
Conversation
trajar
commented
Feb 28, 2012
- Added twitter profile, and original/retweeted status, to tweet object.
- Added tweet entities (tag, url, media, metions) to tweet object
- Updated tweet deserializer to handle the above mentioned elements
- Added proper equals/hashcode to core tweet, profile objects
|
Per commits, I also added proper equals/hashcode to tweet and profile objects, as well as exposing the 'in reply to' user id and screen name tweet attributes. |
…d_entities' into the url
|
Are you planning to include this functionality? I am specially interested in the Entities suppport |
|
Per https://dev.twitter.com/blog/api-housekeeping, it seems that the entity support with become standard API behavior. |
|
It's been six months - any plan on incorporating this enhancement? I'm happy to address any questions/concerns. |
|
I plan to review and, assuming no surprises, merge your change in the next few weeks. Ideally, in time for SpringOne/2GX in mid-October, but seeing as how this is a low priority and I have a TON of other stuff in the queue, I might not get to it until sometime in November. In the meantime, if you've not done so already, it would be helpful if you sign the contributor agreement at https://support.springsource.com/spring_committer_signup yet. Thanks. |
|
Trajar: Was thinking about merging this change soon...possibly today or tomorrow. Can you confirm that you have signed the contributor agreement? |
|
hubuma: My apologies for tardy response. Just signed the contributor agreement. Merge away - let me know if you have any questions. |
update tweet object to expose retweeted status, profile, and entities
|
Only a few comments to make so far:
|
|
FWIW, I've just merged in the changes to fix code style, add some minimal tests, and to default to always fetching entities. I've also extracted the Jackson annotations out of the various entity classes and put them in Jackson mixins, as done in the rest of Spring Social Twitter. I encourage you to review the changes and either fix or let me know if something is out of sorts. |