Roll our own wrapping function for help #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves us writing to a buffer multiple times, and so makes things much, much faster.
SquidDev
added
enhancement
|
I was literally writing a word wrapper. I wasn't sure if I would make it a textutils thing or a cc.pretty thing or a new module. I'll still make a PR and then maybe it can replace this. (Now I'm glad that I didn't actually get anywhere because I was playing games with people.) |
|
So I copied the code from here and started writing tests. This one fails with
I would expect it to see the end of the word |
Lupus590
reviewed
Dec 11, 2020
| end | ||
| else | ||
| -- Print a word normally | ||
| if width - #current_line - 1 < #word then push_line() end |
There was a problem hiding this comment.
Remove the -1 and then text wraps how I expect it to in the conversation tab.
SquidDev
pushed a commit
that referenced
this pull request
Apr 29, 2022
This saves us writing to a buffer multiple times, and so makes things much, much faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves us writing to a buffer multiple times, and so makes things much, much faster.
As in, it's actually usable on copy-cat now!
At this point, it might be worth the actual paginator into a separate utility module. Then we could deprecated
textutils.pagedPrintand point towards that instead - sadly I don't think it's really possible to replicate the behaviour of_nFreeLines.I'm not 100% sure how I feel about exposing entire UI interfaces from a module though. We'll have to see.