Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debian files. #1

Merged
merged 3 commits into from Mar 5, 2020
Merged

Add debian files. #1

merged 3 commits into from Mar 5, 2020

Conversation

@tomac4t
Copy link
Contributor

tomac4t commented Mar 4, 2020

@tomac4t tomac4t marked this pull request as ready for review Mar 4, 2020
Copy link
Member

SilverRainZ left a comment

托马猫辛苦!

pack/debian/control Outdated Show resolved Hide resolved
imagemagick,
libglib2.0-bin,
libgtk-3-dev,
python3 (>= 3.2),

This comment has been minimized.

Copy link
@SilverRainZ

SilverRainZ Mar 5, 2020

Member

因为 df 做这个的时候还是上古时期,依赖现在有些变动了。

  • 不再依赖 python
  • 不再依赖 imagemagick
  • 应该依赖 libsecret-dev,我不知道是不是被其他依赖满足了?
  • 同样是不是应该有类似 libconfig9-dev?
libsoup2.4-1,
libconfig9 (>= 1.5)
Recommends:
libsecret-1-0

This comment has been minimized.

Copy link
@SilverRainZ

SilverRainZ Mar 5, 2020

Member

同上,

  • libsecret-1 应该是必选的运行时依赖
  • 不再需要 python3

This comment has been minimized.

Copy link
@tomac4t

tomac4t Mar 5, 2020

Author Contributor

libsecret-1-0 这个我看到 SrainApp/srain#196 "Works without libsecret" ,所以我理解是可选但不是必要的?@SilverRainZ

This comment has been minimized.

Copy link
@SilverRainZ

SilverRainZ Mar 5, 2020

Member

我表述有问题……其实是 "Works without DBUS secret service",本身二进制还是会 link 到 libsecret.so 的。

pack/debian/copyright Outdated Show resolved Hide resolved
pack/debian/srain-docs.docs Outdated Show resolved Hide resolved
pack/debian/changelog Outdated Show resolved Hide resolved
- Update the dependencies.
- Update the E-mail.
- Remove srain-docs.docs.
@tomac4t

This comment has been minimized.

Copy link
Contributor Author

tomac4t commented Mar 5, 2020

看起来可以了。

@SilverRainZ SilverRainZ merged commit eeb2b69 into SrainApp:master Mar 5, 2020
@tomac4t tomac4t deleted the tomac4t:debian branch Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.