Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append target related error message to corresponding buffer #149

Closed
3 tasks done
SilverRainZ opened this issue Dec 19, 2018 · 0 comments · Fixed by #226
Closed
3 tasks done

Append target related error message to corresponding buffer #149

SilverRainZ opened this issue Dec 19, 2018 · 0 comments · Fixed by #226

Comments

@SilverRainZ
Copy link
Member

SilverRainZ commented Dec 19, 2018

As shown in https://www.alien.net.au/irc/irc2numerics.html, IRC server may returns various error message. Currently Srain always append the error message to current buffer:

https://github.com/SilverRainZ/srain/blob/52351895ffabc38c2ac6839f1dd6aad08897f55a/src/core/app_irc_event.c#L1750

In fact, some of these messages have related to specified buffer. For example, ERR_NOCHANMODES(477) is returned when client try to join a invite only channel. Srain should add this messgae to buffer of this channel but no to current buffer.

  • 477 <channel> Cannot join channel (+r) - you need to be identified with services - see https://freenode.net/kb/answer/registration
  • 473 <channel> Cannot join channel (+i) - you must be invited
  • 475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant