Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent send message icon from breaking on sending a message #144

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@cpba
Copy link
Contributor

commented Oct 24, 2018

After 4dda195 the icon would no longer match the one defined in the glade files.

After 4dda195 the icon would no longer match the one defined in the glade files.
@cpba

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2018

This doesn't appear to completely fix the issue, the icon still breaks for a short instant while the message is sending, then recovers afterwards.

Is there supposed to be a different icon while the message is being sent?

@SilverRainZ

This comment has been minimized.

Copy link
Member

commented Oct 24, 2018

he icon still breaks for a short instant while the message is sending, then recovers afterwards.

Yes, because the neither "dialog-cancel" nor "dialog-ok" is not freedesktop standard icon so that are not include in adwaita icon theme.

I think the standard theme has too few icons so that nothing can be expressed.

@cpba

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2018

Yes, the freedesktop standards really don't cover much, it's just meant to be a base for interoperability.

If it's only a temporal fix until srain gets its own icon, would you consider using something like mail-send-receive? mail-forward or perhaps mail-replied could also work.

@SilverRainZ SilverRainZ merged commit 2e2514f into SrainApp:master Aug 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.