Skip to content

Compare commands case-insensitively#202

Merged
SilverRainZ merged 1 commit into
SrainApp:masterfrom
hhirtz:strcasecmp
Mar 2, 2020
Merged

Compare commands case-insensitively#202
SilverRainZ merged 1 commit into
SrainApp:masterfrom
hhirtz:strcasecmp

Conversation

@hhirtz
Copy link
Copy Markdown
Contributor

@hhirtz hhirtz commented Mar 2, 2020

This brings more flexibility since some servers might send commands that are not all capital letters (e.g. Cap instead of CAP)

@SilverRainZ
Copy link
Copy Markdown
Member

Thanks for you PR~

Can you please fix the strcmp at L232 and L240 ?

Some servers may send commands without capital letters.
@hhirtz
Copy link
Copy Markdown
Contributor Author

hhirtz commented Mar 2, 2020

done, wasn't sure if they should have been replaced

@SilverRainZ SilverRainZ merged commit a6cb289 into SrainApp:master Mar 2, 2020
@hhirtz hhirtz deleted the strcasecmp branch March 2, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants