Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare commands case-insensitively #202

Merged
merged 1 commit into from Mar 2, 2020
Merged

Conversation

@hhirtz
Copy link
Contributor

hhirtz commented Mar 2, 2020

This brings more flexibility since some servers might send commands that are not all capital letters (e.g. Cap instead of CAP)

@SilverRainZ

This comment has been minimized.

Copy link
Member

SilverRainZ commented Mar 2, 2020

Thanks for you PR~

Can you please fix the strcmp at L232 and L240 ?

@SilverRainZ SilverRainZ self-requested a review Mar 2, 2020
Some servers may send commands without capital letters.
@hhirtz hhirtz force-pushed the hhirtz:strcasecmp branch from 6f17b88 to 7f83e6b Mar 2, 2020
@hhirtz

This comment has been minimized.

Copy link
Contributor Author

hhirtz commented Mar 2, 2020

done, wasn't sure if they should have been replaced

@SilverRainZ SilverRainZ merged commit a6cb289 into SrainApp:master Mar 2, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hhirtz hhirtz deleted the hhirtz:strcasecmp branch Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.