Truncate long message and Improve message transcoding #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SilverRainZ
commented
Mar 23, 2020
SilverRainZ
commented
- Introduce SircCommandBuilder to build IRC message with legal length
- Deal with invalid UTF-8 sequence
- Prevent uncessary transcoding
SilverRainZ
force-pushed
the
bugfix/send-long-message
branch
from
af85e30
to
a808a17
Compare
- For to_codeset, we only need UTF-8 is need, because GTK only supports UTF-8 - Deal with invalid UTF-8 sequence - Prevent uncessary convertion when from_codeset is UTF-8 as well
SilverRainZ
force-pushed
the
bugfix/send-long-message
branch
from
a808a17
to
d946e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.