Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data/builtin.cfg: Fix syntax errors caused by trailing commas #330

Merged
merged 1 commit into from
Aug 29, 2021

Conversation

progval
Copy link
Member

@progval progval commented Aug 28, 2021

No description provided.

@SilverRainZ
Copy link
Member

I think the trailing commas is allowed by libconfig, can you please paste the error message?

@progval
Copy link
Member Author

progval commented Aug 29, 2021

I get a popup saying "Failed to read system configuration file: At line 110: syntax error"

@SilverRainZ
Copy link
Member

Get it, trailing commas is not allowed before libconfig 1.7[1], let's be compatible with the old version.

[1] https://github.com/hyperrealm/libconfig/blob/77d5bf5ad8cb98e15660a209aaf9bd46c97d7d9e/ChangeLog#L95

@SilverRainZ SilverRainZ merged commit b898c35 into SrainApp:master Aug 29, 2021
@progval progval deleted the doc-commas branch August 29, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants