Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ISUPPORT parsing + the UTF8ONLY IRCv3 specification #331

Merged
merged 1 commit into from
Sep 4, 2021

Conversation

progval
Copy link
Member

@progval progval commented Aug 28, 2021

ISUPPORT syntax: https://modern.ircdocs.horse/#rplisupport-005

Relevant bits from the UTF8ONLY specification:

Servers publishing this token MUST NOT relay content [...] containing non-UTF-8 data to clients

If a client implementing this specification sees this token, they MUST set their outgoing encoding to UTF-8 without requiring any user intervention.

This has the following effects:

  • With the default configuration, this does nothing because Srain uses UTF-8 by default
  • If a non-UTF-8 encoding is specified, it overrides the user's configuration if the server advertises UTF8ONLY.

This seems to affect only the incoming encoding, because Srain always send UTF-8 regardless of how I configured it. (Which is nice IMO, but it looks like a bug.)

@SilverRainZ SilverRainZ merged commit 2234bd9 into SrainApp:master Sep 4, 2021
@progval progval deleted the utf8only branch September 4, 2021 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants