Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nick completion case-insensitive #333

Merged
merged 2 commits into from
Aug 29, 2021

Conversation

progval
Copy link
Member

@progval progval commented Aug 28, 2021

Closes GH-305.

Copy link
Member

@SilverRainZ SilverRainZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work :D

@@ -234,7 +235,15 @@ void sui_completion_complete(SuiCompletion *self, SuiCompletionFunc *func,
DBG_FR("Completion: prefix: '%s', suffix: '%s'",
self->last_prefix, self->last_suffix);


// Go backward, to remove the prefix
assert(gtk_text_iter_backward_chars(&comp, g_utf8_strlen(self->last_prefix, -1)));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use assert here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason in particular, I just don't like to ignore error return values. I can remove it if you prefer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For glib application, we can use g_warn_if_fail (just warning)or g_return_if_fail(warn and return).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, done!

@SilverRainZ SilverRainZ merged commit badf813 into SrainApp:master Aug 29, 2021
@progval progval deleted the caseinsensitive-completion branch August 29, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nick complete case sensitive
2 participants