Add support for channel messages with origin out of channel #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On channels with mode -n, people don't need to be in the channel to send messages to it. MODE and KICK can also be used by network bots or servers, even if they are not joined.
|
I am not sure whether we need to open a new buffer for receiving such messages, we can see it at the server buffer, isn't it? |
|
IIRC the current behavior is to drop the message entirely. With this PR, it is shown in the target channel |
SilverRainZ
approved these changes
Nov 20, 2021
SilverRainZ
added a commit
that referenced
this pull request
Dec 18, 2021
Add support for channel messages with origin out of channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On channels with mode -n, people don't need to be in the channel
to send messages to it.
MODE and KICK can also be used by network bots or servers,
even if they are not joined.