Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macos build #339

Merged
merged 4 commits into from
Oct 6, 2021
Merged

Fix macos build #339

merged 4 commits into from
Oct 6, 2021

Conversation

SilverRainZ
Copy link
Member

No description provided.

@ZachBacon
Copy link

I can confirm this does in fact compile on macos again, apologies for not contributing much sooner to the health of the macos specifics, I kinda lost access to my hackintosh setup, but I have an m1 macbook air that I was able to test using both homebrew instructions and using JHBUILD to test this branch out.

@SilverRainZ
Copy link
Member Author

@ZachBacon, That sounds good, can you add srain to homebrew's offical repo if we have finished the test?

@SilverRainZ SilverRainZ merged commit bfe78c8 into master Oct 6, 2021
@SilverRainZ SilverRainZ deleted the bugfix/macos-build branch October 6, 2021 16:06
@ZachBacon
Copy link

I can at some point, more or less on the weekend though

@SilverRainZ
Copy link
Member Author

@ZachBacon any updates?

@ZachBacon
Copy link

@ZachBacon any updates?

Not until the weekend, my work week is fairly busy currently.

@ZachBacon
Copy link

@SilverRainZ so regarding the build, sorry it took me a while. As I've stated work has been busy (understaffed sadly) but the build I've been using the instructions here https://gitlab.gnome.org/GNOME/gtk-osx

from there once I got gtk3 compiled, via the jhbuild shell, I had to manually compile libconfig as well as install via pip the doc building tools (which to be honest should be made optional so that builds can still happen even without the doc tools). Once I met those requirements I was able to compile srain. Though, I'm working on a slightly easier setup that doesn't rely on brew or jhbuild. This way a proper app bundle for macOS can be automatically built without too much fuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants