Make the buffer menu apply to the right-clicked item instead of the active buffer#353
Merged
Merged
Conversation
…ctive buffer I find it confusing that click-clicking does not apply to the clicked element. This commit inserts a GtkEventBox containing the SuiSideBarItem in GtkListBoxRow instead of inserting SuiSideBarItem directly.
SilverRainZ
reviewed
Feb 26, 2022
SilverRainZ
approved these changes
Feb 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find it confusing that click-clicking does not apply to the clicked element.
This commit inserts a GtkEventBox containing the SuiSideBarItem in GtkListBoxRow
instead of inserting SuiSideBarItem directly.
Here is the difference when right-clicking a channel buffer while a server buffer is active:
Before:
After:
Another difference is that clicking the empty space of the ListBox no longer shows a menu at all.